[arrow-flight encode path]re-use flatbufferbuilder#10220
Open
Rich-T-kid wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
cc @alamb |
Contributor
|
run benchmark flight |
alamb
reviewed
Jun 27, 2026
|
|
||
| impl CompressionContext { | ||
| /// Takes the stored fbb, leaving a zero-capacity placeholder. Must be returned via [`Self::return_fbb`]. | ||
| pub(crate) fn take_fbb(&mut self) -> FlatBufferBuilder<'static> { |
Contributor
There was a problem hiding this comment.
Do you need to provide a take/return? Would it be possible to just reutrn a mut reference?
LIke
pub(crate) fn fbb_mut(&mut self) -> & mut FlatBufferBuilder<'static> {I think that would simplify the code a bit (and wouldn't require creating an empyt builder either)
Contributor
Author
There was a problem hiding this comment.
makes sense to me.
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/re-use-allocations (e9f85aa) to 44f3772 (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Rich-T-kid
force-pushed
the
rich-T-kid/re-use-allocations
branch
from
e9f85aa to
9fadcd7
Compare
Contributor
Author
|
🤔 i've been thinking about changing the benchmarks to avoid having tokio polling be a factor. It may be more useful to benchmark the top level entry functions I.E
directly the decode path wasnt touched in this PR but its showing a drastic change we have no control over the tokio run time so it makes sense to avoid it in the benchmarks if we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
flat buffer builder was being allocated repeatedly when it could be created once and reset using
fbb.resetWhat changes are included in this PR?
provides methods for setting and getting fbb. This avoids needing to re-allocate it on every call
Are these changes tested?
Are there any user-facing changes?